Merge develop fix for widescreens to master#165
Merged
trumanjchan merged 3 commits intomasterfrom Apr 30, 2021
Merged
Conversation
Added a min-width media query so resolution widths above 650px lock the home heading component's height to 700px. This is responsive until hitting 2000px width, where the tower's tip starts going up into the navbar and revealing the tower's bottom.
Over 800px height, the tower height will follow the height of the screen. Perfect for 1100px height and under. Both tower height and home heading component height are good until 2000px width.
Fixed Home Heading height for higher than 650px width, up to 2000px
adriandarian
pushed a commit
that referenced
this pull request
Oct 18, 2021
Merge develop fix for widescreens to master
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Urgent fix, for widescreens.
Types of changes
What types of changes does your code introduce to HackMerced Hub?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Responsiveness
Check off the different browsers and devices you have tested on. Note: testing includes Horizontal and Vertical alignments
Browsers
Devices
Phones
Tablets
Desktops
Screenshots
Further comments
Need a media query fix for this PR change: https://www.notion.so/createdmary/Engineering-3d2b20e70a644593a7c4740cd5e31f33?p=99f5abcae1704bae94dd635483d752a8