Merged
Conversation
Mobile hexagon hover, where the user long-presses a hexagon and swipes somewhere outside of the hexagon and lets go, was making the hover text really large at lower resolutions like phones. So I had to move the texts upwards at different resolutions, and change text size.
Fixed responsiveness for desktop and mobile all the way down to 300px
Front page fix (updated)
Didn't need the opacity to be changed. The break-lines will be visible without changing the opacity for some reason...
Deleted opacity for break-lines on home page
Fixed up comments in the .scss file, added new members to hexagons, and fixed hexagons component centering.
Added new members to hexagons
Added Shawn's pic to hexagons. Saw that the HackMerced Tower was placed very low on the home page, so I changed the margins, height, and widths of it. Changed CSS and media queries so the tower, title img, title texts, and subscribe button have proper z-indexes when overlapping, and fixed minor responsiveness issues relating to that.
Now Clouds will always float OVER the Tower. Above 1030px width, Clouds float OVER and UNDER the title img, texts, and subscribe button, but under 1030px width Clouds always float under the title img, texts, and subscribe button (because z-index).
Added Shawn's pic to hexagons, cleaned up some CSS
The Home Heading's img, text, subtext, and subscribe button were too squished together. I had to change the height of the Home Heading component and add css to that, and fix the css margins between the subtext and subscribe button. By doing this we fill most of the empty space in our Heading component; especially when at lower resolutions.
Had to subtract the vh by the height of the navbar's height. Will not do vh for lower resolutions because lower resolutions are for phones and other devices. Apparently vh might not work on them and create visual bugs (because you can zoom-in and scroll out of the page using a phone, changing the view height).
Changed Home Heading height w/ heading subtext & button margin
Navbar colour changes in mobile view. The colours in dark and light themes are different.
The colour at present is set to "rgb(255, 177, 129)"
Changed the navbar colour
Implemented hover feature animation for the navbar. Fixed breaklines having full width of the div by using margins as inner div padding (this is needed because it doesn't make sense to have a full width breakline under "Home").
Added navbar hover feature, & fixed breaklines width in hamburger navbar
to the hexagons! Only two more members' pictures. I also made the backdrop filter for the hover feature more blurry, so the title is easier to read when on top of white backgrounds.
All hexagons are now finalized, but can be changed at any time if members want to edit their picture.
to the hexagons.
Hexagons are now all filled.
…x/hexagons-newmembers
Fix/hexagons newmembers (FINAL)
adriandarian
pushed a commit
that referenced
this pull request
Oct 18, 2021
Merging Develop with Master
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Types of changes
What types of changes does your code introduce to HackMerced Hub?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Responsiveness
Check off the different browsers and devices you have tested on. Note: testing includes Horizontal and Vertical alignments
Browsers
Devices
Phones
Tablets
Desktops
Screenshots
Before this PR:






After this PR:
Before with hexagon hover feature:
After with revised hexagon hover feature:
Before with navbar breaklines taking full width in mobile view, & navbar background color not changing, & subscribe button too clumped up with subtext:
After with navbar breaklines NOT taking full width in mobile view, & navbar background color change with dark-mode toggle, & margin updates with home header img, text, subtext, and subscribe button, & navbar hover animation:
Further comments
Welcome, new members!