Skip to content

Fix/hexagons newmembers (FINAL)#162

Merged
trumanjchan merged 5 commits intodevelopfrom
fix/hexagons-newmembers
Apr 30, 2021
Merged

Fix/hexagons newmembers (FINAL)#162
trumanjchan merged 5 commits intodevelopfrom
fix/hexagons-newmembers

Conversation

@trumanjchan
Copy link
Copy Markdown
Contributor

@trumanjchan trumanjchan commented Apr 29, 2021

Proposed changes

Added in all the new members' images to the hexagons.

Types of changes

What types of changes does your code introduce to HackMerced Hub?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Responsiveness

Check off the different browsers and devices you have tested on. Note: testing includes Horizontal and Vertical alignments

Browsers

  • Chrome
  • Firefox
  • Edge
  • Safari
  • Brave
  • Opera

Devices

Phones

  • Moto G4
  • Galaxy S5
  • Pixel 2
  • Pixel 2 XL
  • iPhone 5/SE
  • iPhone 6/7/8
  • iPhone 6/7/8 Plus
  • iPhone X

Tablets

  • iPad
  • iPad Pro

Desktops

  • Windows 10
  • MacOSX
  • Ubuntu

Screenshots

image
After adding in Shakti:
image
Revised Hexagon Hover Background:
image
image
image

Further comments

Members can change their image at any time by making a Pull Request (PR). Safari should support the hexagon hover feature. And someone should check if Opera supports the hexagon hover feature. Instead of doing a bunch of @supports () {}, or calling -webkit-, -moz-, and -o- separately, I just changed it so the background color is the same for all browsers.

to the hexagons! Only two more members' pictures. I also made the backdrop filter for the hover feature more blurry, so the title is easier to read when on top of white backgrounds.
All hexagons are now finalized, but can be changed at any time if members want to edit their picture.
@trumanjchan trumanjchan added the Fix Fixing a known bug label Apr 29, 2021
@trumanjchan trumanjchan self-assigned this Apr 29, 2021
@github-actions github-actions bot added the react label Apr 29, 2021
@trumanjchan
Copy link
Copy Markdown
Contributor Author

Oops, forgot Shakti. Will add him in when he uploads his pic.

@trumanjchan trumanjchan merged commit 195f936 into develop Apr 30, 2021
@delete-merged-branch delete-merged-branch bot deleted the fix/hexagons-newmembers branch April 30, 2021 18:30
adriandarian pushed a commit that referenced this pull request Oct 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Fix Fixing a known bug react

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant