Skip to content

Changed the navbar colour#160

Merged
trumanjchan merged 2 commits intodevelopfrom
fix/navbar-colorchange
Apr 26, 2021
Merged

Changed the navbar colour#160
trumanjchan merged 2 commits intodevelopfrom
fix/navbar-colorchange

Conversation

@Abdus-Samee
Copy link
Copy Markdown
Member

Navbar colour changes in mobile view. The colours in dark and light themes are different.

Proposed changes

This pull request changes the navbar colour whenever the theme of the website changes. The colours assigned for the dark and light themes are different.

Types of changes

What types of changes does your code introduce to HackMerced Hub?
Put an x in the boxes that apply

  • [x ] Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Responsiveness

Check off the different browsers and devices you have tested on. Note: testing includes Horizontal and Vertical alignments

Browsers

  • [x ] Chrome
  • [x ] Firefox
  • [ x] Edge
  • Safari
  • Brave
  • Opera

Devices

Phones

  • [ x] Moto G4
  • [x ] Galaxy S5
  • [x ] Pixel 2
  • [x ] Pixel 2 XL
  • [ x] iPhone 5/SE
  • [ x] iPhone 6/7/8
  • [x ] iPhone 6/7/8 Plus
  • [x ] iPhone X

Tablets

  • [x ] iPad
  • [ x] iPad Pro

Desktops

  • [x ] Windows 10
  • MacOSX
  • Ubuntu

Screenshots

Please attach at least one Desktop and Mobile screenshot of your update.
desc
desc-1
mb-1
mb-2

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

Navbar colour changes in mobile view. The colours in dark and light themes are different.
@github-actions github-actions bot added the react label Apr 26, 2021
The colour at present is set to "rgb(255, 177, 129)"
@Abdus-Samee Abdus-Samee requested a review from trumanjchan April 26, 2021 17:01
@Abdus-Samee Abdus-Samee self-assigned this Apr 26, 2021
@trumanjchan trumanjchan added the Fix Fixing a known bug label Apr 26, 2021
@trumanjchan trumanjchan merged commit c2486a5 into develop Apr 26, 2021
@delete-merged-branch delete-merged-branch bot deleted the fix/navbar-colorchange branch April 26, 2021 17:04
adriandarian pushed a commit that referenced this pull request Oct 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Fix Fixing a known bug react

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants