Added Shawn's pic to hexagons, cleaned up some CSS#158
Merged
trumanjchan merged 2 commits intodevelopfrom Apr 21, 2021
Merged
Conversation
Added Shawn's pic to hexagons. Saw that the HackMerced Tower was placed very low on the home page, so I changed the margins, height, and widths of it. Changed CSS and media queries so the tower, title img, title texts, and subscribe button have proper z-indexes when overlapping, and fixed minor responsiveness issues relating to that.
Now Clouds will always float OVER the Tower. Above 1030px width, Clouds float OVER and UNDER the title img, texts, and subscribe button, but under 1030px width Clouds always float under the title img, texts, and subscribe button (because z-index).
adriandarian
pushed a commit
that referenced
this pull request
Oct 18, 2021
Added Shawn's pic to hexagons, cleaned up some CSS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Added Shawn's pic to hexagons. Saw that the HackMerced Tower was placed very low on the home page, so I changed the margins, height, and widths of it. Changed CSS and media queries so the tower, title img, title texts, and subscribe button to have proper z-indexes when overlapping, and fixed minor responsiveness issues relating to that.
Types of changes
What types of changes does your code introduce to HackMerced Hub?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Responsiveness
Check off the different browsers and devices you have tested on. Note: testing includes Horizontal and Vertical alignments
Browsers
Devices
Phones
Tablets
Desktops
Screenshots
Before commits (1600px width):
After commits:
Before commits (801 width):
After commits:
Further comments
I realized that every time I boot up the hackmerced website, the tower image on the left is very low (I can't see the actual "Hack Merced" letters). So I wanted to fix this because people should be able to see the words on the tower. Looks better anyways.