Skip to content

Fixed responsiveness for desktop and mobile all the way down to 300px#154

Merged
adriandarian merged 1 commit intodevelopfrom
fix/hexagons
Mar 31, 2021
Merged

Fixed responsiveness for desktop and mobile all the way down to 300px#154
adriandarian merged 1 commit intodevelopfrom
fix/hexagons

Conversation

@trumanjchan
Copy link
Copy Markdown
Contributor

@trumanjchan trumanjchan commented Mar 31, 2021

Mobile hexagon hover, where the user long-presses a hexagon and swipes somewhere outside of the hexagon and lets go, was making the hover text really large at lower resolutions like phones. So I had to move the texts upwards at different resolutions, and change text size.

Proposed changes

Had responsiveness for res width 800px or higher, but now hexagon hover is fully responsive from 300px - max width! Also fixed responsiveness for mobile view, so that works too now.

Types of changes

What types of changes does your code introduce to HackMerced Hub?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Responsiveness

Check off the different browsers and devices you have tested on. Note: testing includes Horizontal and Vertical alignments

Browsers

  • Chrome
  • Firefox
  • Edge
  • Safari
  • Brave
  • Opera

Devices

Phones

  • Moto G4
  • Galaxy S5
  • Pixel 2
  • Pixel 2 XL
  • iPhone 5/SE
  • iPhone 6/7/8
  • iPhone 6/7/8 Plus
  • iPhone X

Tablets

  • iPad
  • iPad Pro

Desktops

  • Windows 10
  • MacOSX
  • Ubuntu

Screenshots

Desktop view:
image
image
image

Mobile view:
image

Further comments

N/A

Mobile hexagon hover, where the user long-presses a hexagon and swipes somewhere outside of the hexagon and lets go, was making the hover text really large at lower resolutions like phones. So I had to move the texts upwards at different resolutions, and change text size.
@trumanjchan trumanjchan added the Fix Fixing a known bug label Mar 31, 2021
@trumanjchan trumanjchan self-assigned this Mar 31, 2021
@github-actions github-actions bot added the react label Mar 31, 2021
@adriandarian adriandarian merged commit a1a902e into develop Mar 31, 2021
@delete-merged-branch delete-merged-branch bot deleted the fix/hexagons branch March 31, 2021 04:10
Copy link
Copy Markdown
Member

@adriandarian adriandarian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

adriandarian added a commit that referenced this pull request Oct 18, 2021
Fixed responsiveness for desktop and mobile all the way down to 300px
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Fix Fixing a known bug react

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants