Skip to content

Fixed Hexagon Responsiveness that resulted from removal of tailwind#147

Merged
maryharebear merged 2 commits intodevelopfrom
fix/hexagons
Mar 25, 2021
Merged

Fixed Hexagon Responsiveness that resulted from removal of tailwind#147
maryharebear merged 2 commits intodevelopfrom
fix/hexagons

Conversation

@trumanjchan
Copy link
Copy Markdown
Contributor

@trumanjchan trumanjchan commented Mar 23, 2021

Images were very zoomed in, so I had to put a two liner where width and height of the images are now 100% sized. Also had to manually recenter the entire container. Imported Joseph's new profile pic.

Proposed changes

Had to change the honeycomb layout because our leaving/graduating members needed to be removed.

Types of changes

What types of changes does your code introduce to HackMerced Hub?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Responsiveness

Check off the different browsers and devices you have tested on. Note: testing includes Horizontal and Vertical alignments

Browsers

  • Chrome
  • Firefox
  • Edge
  • Safari
  • Brave
  • Opera

Devices

Phones

  • Moto G4
  • Galaxy S5
  • Pixel 2
  • Pixel 2 XL
  • iPhone 5/SE
  • iPhone 6/7/8
  • iPhone 6/7/8 Plus
  • iPhone X

Tablets

  • iPad
  • iPad Pro

Desktops

  • Windows 10
  • MacOSX
  • Ubuntu

Screenshots

image
image
Fixed lower width resolution centering with media queries:
image

Further comments

I think the Past Winners icons and titles are not centered in their component.

Images were very zoomed in, so I had to put a two liner where width and height of the images are now 100% sized. Imported Joseph's new profile pic.
@trumanjchan trumanjchan added the Fix Fixing a known bug label Mar 23, 2021
@trumanjchan trumanjchan self-assigned this Mar 23, 2021
@github-actions github-actions bot added the react label Mar 23, 2021
@maryharebear maryharebear merged commit 523110e into develop Mar 25, 2021
@delete-merged-branch delete-merged-branch bot deleted the fix/hexagons branch March 25, 2021 02:19
adriandarian pushed a commit that referenced this pull request Oct 18, 2021
Fixed Hexagon Responsiveness that resulted from removal of tailwind
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Fix Fixing a known bug react

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants