Skip to content

Changed up the codebase#145

Merged
maryharebear merged 34 commits intomasterfrom
develop
Mar 26, 2021
Merged

Changed up the codebase#145
maryharebear merged 34 commits intomasterfrom
develop

Conversation

@adriandarian
Copy link
Copy Markdown
Member

Proposed changes

Went through and removed components that were not acting like reusable components and just migrated them into the pages. Linted all files. As well changed the css class names to a modernized approach.

Types of changes

What types of changes does your code introduce to HackMerced Hub?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Responsiveness

Check off the different browsers and devices you have tested on. Note: testing includes Horizontal and Vertical alignments

Browsers

  • Chrome
  • Firefox
  • Edge
  • Safari
  • Brave
  • Opera

Devices

Phones

  • Moto G4
  • Galaxy S5
  • Pixel 2
  • Pixel 2 XL
  • iPhone 5/SE
  • iPhone 6/7/8
  • iPhone 6/7/8 Plus
  • iPhone X

Tablets

  • iPad
  • iPad Pro

Desktops

  • Windows 10
  • MacOSX
  • Ubuntu

Screenshots

Please attach at least one Desktop and Mobile screenshot of your update.

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

maryharebear and others added 29 commits March 15, 2021 19:02
Reorganized the honeycomb design, shortened the scss code, added notes in scss file. Need new members' profile pictures: Sean and Gehad.
adriandarian and others added 5 commits March 23, 2021 09:01
chore: documented quite a bit of files
Images were very zoomed in, so I had to put a two liner where width and height of the images are now 100% sized. Imported Joseph's new profile pic.
Fixed Hexagon Responsiveness that resulted from removal of tailwind
@maryharebear maryharebear merged commit 83400bb into master Mar 26, 2021
adriandarian pushed a commit that referenced this pull request Oct 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants