Merged
Conversation
JeyzerMC
reviewed
Jul 14, 2018
server/schema/schema.json
Outdated
| @@ -0,0 +1,69 @@ | |||
| "users": | |||
There was a problem hiding this comment.
I asked in the wrong PR, but what is the benefits of having both each schema and a container schema?
There was a problem hiding this comment.
Like what is this specific file used for? It's a concatenation of all the other schemas, that's why
JeyzerMC
reviewed
Jul 14, 2018
server/schema/volunteers.json
Outdated
| "phone": "{{chance.phone()}}", | ||
| "email": "{{chance.email()}}", | ||
| "shirt_size": "{{util.sample(['X-Small', 'Small', 'Medium', 'Large', 'X-Large'])}}", | ||
| "availability": "" |
There was a problem hiding this comment.
Should that be an array since the event will be over the span of 3 days?
Member
There was a problem hiding this comment.
look at the typeform I made for the volunteer listing, I added the time slots we are looking for there and a list of days
we should have those as two separate fields
adriandarian
added
bug
adriandarian
approved these changes
Jul 17, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.