Allow for execution on Windows, although this breaks time-out handling.#21
Closed
southernsun wants to merge 1 commit intoHDE:masterfrom
southernsun:patch-1
Closed
Allow for execution on Windows, although this breaks time-out handling.#21southernsun wants to merge 1 commit intoHDE:masterfrom southernsun:patch-1
southernsun wants to merge 1 commit intoHDE:masterfrom
southernsun:patch-1
Conversation
by checking if SIGALRM exists we can determine if it is either running on UNIX or Windows. If it is running on Windows, ignore the timeout feature and just continue.
Collaborator
|
Hi, thank you for your contribution. Since AWS Lambda itself runs under Linux environment (See http://docs.aws.amazon.com/lambda/latest/dg/current-supported-versions.html), I guess it's better to output a warning if it is executed in Windows environment, so that users understand |
Contributor
|
See: #32 |
Collaborator
|
Implemented in #32, released via version 0.1.6. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
by checking if SIGALRM exists we can determine if it is either running on UNIX or Windows. If it is running on Windows, ignore the timeout feature and just continue.