Support a wider range of PHP Versions #39
Conversation
There was a problem hiding this comment.
Pull request overview
This PR attempts to broaden PHP version support from PHP 8.4+ down to PHP 8.2+ to make the library accessible to projects not yet targeting Symfony 8.0. However, there are critical dependency compatibility issues that prevent this from working.
Key Changes:
- PHP version requirement lowered from >= 8.4 to >= 8.2
- Symfony components downgraded from 8.1.x-dev to 7.3.x-dev/7.4.x-dev branches
- PHPUnit version range expanded to support both 12.5 and 13.0
Reviewed changes
Copilot reviewed 3 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| composer.json | Updates PHP requirement to >= 8.2 and adjusts PHPUnit version constraint to support 12.5 or 13.0 |
| composer.lock | Reflects dependency resolution with downgraded Symfony components and PHPUnit 12.5, but contains incompatible dependencies requiring PHP 8.3+ |
| tests/SymfonyXmlFixturesTest.php | Applies stylistic code formatting change (wrapping instantiation in parentheses) with no functional impact |
| .github/workflows/tests.yml | Updates CI workflow to test against PHP 8.2 instead of 8.4 |
| .gitignore | Adds /output/ directory to ignored files |
Critical Issues: The composer.lock file contains resolved dependencies that require PHP >= 8.3, including the production dependency sebastian/diff and the dev dependency phpunit/phpunit. This makes the package uninstallable on PHP 8.2, contradicting the PR's stated goal. The dependency versions need to be adjusted to versions that support PHP 8.2 before this change can work as intended.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
This 2 lines need to be wrapped with parenthesis: symfony-config-xml-to-php/src/ConvertCommand.php Lines 134 to 135 in 1d878ed |
| "symfony/expression-language": "7.4.*", | ||
| "sebastian/diff": "^7.0" | ||
| "sebastian/diff": "^6.0 || ^7.0" | ||
| }, |
There was a problem hiding this comment.
Should we add the platform.php config here to ensure that composer.lock is generated on updates to PHP 8.2, not the maintainer's local version?
|
Thank you @alexander-schranz |
3 participants
To make it easier to tackle this task also already for libraries not yet targetting Symfony 8.0 but want get rid of the XMLs.