Use ::class notation for every string that looks like a FQCN
#37
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the codebase to use PHP's ::class notation for all fully qualified class names (FQCNs) instead of string literals. The main change enhances the converter logic to detect FQCN-like strings using a regex pattern, ensuring consistent use of ::class notation throughout the generated configuration files.
Key Changes:
- Enhanced the
formatString()method to detect FQCN patterns using regex in addition to checking for existing classes/interfaces/traits/enums - Updated test fixtures to reflect the new
::classnotation for all service definitions - Removed an unnecessary blank line in the validation method
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/XmlToPhpConfigConverter.php | Added regex pattern matching to detect FQCN-like strings and format them with ::class notation |
| tests/Fixtures/config/all_features.php | Updated all service definitions to use ::class notation instead of string literals for class names |
| src/ConvertCommand.php | Removed extraneous blank line in the validation method |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| if (class_exists($value) || interface_exists($value) || trait_exists($value) || enum_exists($value) | ||
| || str_contains($value, '\\') && preg_match('/(?(DEFINE)(?<V>[a-zA-Z_\x7f-\xff][a-zA-Z0-9_\x7f-\xff]*+))^(?&V)(?:\\\\(?&V))*+$/', $value)) { |
There was a problem hiding this comment.
The regex pattern is complex and lacks explanation. Consider extracting it to a named constant with documentation explaining that it validates PHP namespace and class name syntax according to PHP's identifier rules.
Closes #30