Run tests with full features and fix expression factory #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR enhances test coverage by running tests with full Symfony DI container features and fixes expression-based factory handling in the XML to PHP config converter.
Key Changes:
- Added support for expression-based factory configurations in the converter
- Extended test fixtures to include comprehensive Symfony DI features
- Expanded test coverage to include additional config fixture files
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/SymfonyXmlFixturesTest.php | Adds tests/Fixtures/config/ directory to XML fixture discovery |
| tests/Fixtures/config/imported_file.php | New test fixture demonstrating PHP-based service imports |
| tests/Fixtures/config/all_features.xml | Comments out problematic stack services section pending fix |
| tests/Fixtures/config/all_features.php | Comprehensive PHP config fixture covering all DI container features |
| src/XmlToPhpConfigConverter.php | Adds expression attribute handling for factory and callable configurations |
| composer.json | Explicitly declares ext-dom dependency |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
stof
reviewed
Dec 2, 2025
| "minimum-stability": "dev", | ||
| "require": { | ||
| "php": ">= 8.4", | ||
| "ext-dom": "*", |
Contributor
There was a problem hiding this comment.
this causes the committed composer.lock file to be considered outdated. You should either remove the committed lock file or ensure that the committed lock file is in sync.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.