Avoid overwriting arguments w/o name or key in the PHP array #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug in the XML to PHP configuration converter where arguments without explicit names or keys in PHP arrays were being incorrectly handled. The issue was caused by the original key variable being overwritten with its formatted version before checking if a key exists.
Key changes:
- Renamed variable to separate original key from formatted key in
formatArgument()method - Added test fixture for service arguments without explicit index attributes
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/XmlToPhpConfigConverter.php | Fixed variable naming bug by using $itemKeyFormatted to store the formatted key instead of overwriting $itemKey, ensuring the original key value is preserved for the existence check |
| tests/Fixtures/config/all_features.xml | Added test case for service with arguments that don't have explicit index attributes to verify the fix handles sequential arguments correctly |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hope this fixes #33.