Complete rewrite #23
Merged
Complete rewrite #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR implements a complete rewrite of the XML to PHP config converter, transforming it from a simple script to a comprehensive library with proper error handling, validation, and test coverage using Symfony's own test fixtures.
- Replaced the simple script with a structured class-based converter
- Added comprehensive test coverage using Symfony's DI XML fixtures
- Implemented validation by comparing XML dumps of converted PHP files
Reviewed Changes
Copilot reviewed 9 out of 12 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/SymfonyXmlFixturesTest.php | Comprehensive test suite using Symfony's XML fixtures with validation |
| src/XmlToPhpConfigConverter.php | Main converter class with complete XML to PHP DSL conversion logic |
| src/ConvertCommand.php | Console command for file/directory conversion with validation |
| phpunit.xml | PHPUnit configuration for running tests |
| convert_xml_to_php.php | Removed old conversion script |
| composer.json | Project configuration with Symfony dependencies |
| README.md | Updated documentation with new usage instructions |
| LICENSE | MIT license file |
| .github/workflows/tests.yml | CI workflow for automated testing |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing using the fixtures from Symfony tests:
./bin/convert vendor/symfony/dependency-injection/Tests/Fixtures/xml/Fixes:
<service>tag #16