Skip to content

Fixed issue with undefined initial zoom - #790

Closed
More4ever wants to merge 1 commit into
GoogleMapReact:masterfrom
More4ever:patch-1
Closed

More4ever wants to merge 1 commit into
GoogleMapReact:masterfrom
More4ever:patch-1

Conversation

@More4ever

Copy link
Copy Markdown

Resolved Issue:
mount zoom value is not set, in process of work we set zoom to any value (eg. 12).

Math.abs(nextProps.zoom - this.props.zoom) > 0 condition is always false

Math.abs(12 - undefined) = NaN

Issue: mount zoom value is not set, in process of work we set zoom to any value (eg. 12). condition always `false`
`Math.abs(12 - undefined)` = `NaN`
@itsmichaeldiego

Copy link
Copy Markdown
Member

@More4ever Is this from an open issue?

@More4ever

Copy link
Copy Markdown
Author

Not sure it was too many days ago

Probably it exists only as PR. I can create issue with same description and source code links if it is required

@itsmichaeldiego

Copy link
Copy Markdown
Member

@More4ever The problem is that I don't see the issue happening, so I don't know what you are fixing. Therefore yes, please!

@itsmichaeldiego

Copy link
Copy Markdown
Member

@More4ever I think this is a duplicate of #864, and I think #864 fixes the problem way better, what do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants