Repository navigation
Conversation
This allows the new context API to propagate context properly.
|
this effectively means this component no longer supports react 15 - is this wise? we still use this component in a react 15 code base - its not always that trivial to move to the latest react on a large codebase |
|
@jooj123 I am wondering if we should catch when the user is using 16+ and apply this code when so. |
|
@itsmichaeldiego yeah some sort of fallback would be good |
|
React 16 has been out for over a year at this point and upgrading really isn't that difficult IMO. I can understand that we don't want to making a breaking change like this in a minor version but we can't continue to support React < 16 indefinitely. It seems reasonable to me, at this point, that we publish a new major version with this breaking change and that the current version continues to live on as is. If you want the latest and greatest features of anything you have to upgrade versions and deal with the migration (which from React 15 - 16 really is not that much). If you're happy with React 15 then by all means you can keep using it but the community has to move forward. A year is a long time in the frontend JavaScript world. |
|
@clayne11 I agree with you on this one, totally. I will try to prepare a major release soon with this change. |
This allows the new context API to propagate context properly.
Fixes #642.
Note: This is a breaking change since it will no longer support React < 16 and should be released as a new major version.