Skip to content

fix error about fromLatLngToDivPixel - #517

Merged
itsmichaeldiego merged 2 commits into
GoogleMapReact:masterfrom
fmy:patch-1
Feb 23, 2018
Merged

itsmichaeldiego merged 2 commits into
GoogleMapReact:masterfrom
fmy:patch-1

Conversation

@fmy

@fmy fmy commented Feb 19, 2018 •

Copy link
Copy Markdown
Contributor

fix "Cannot read property 'fromLatLngToDivPixel' of undefined" #257

In my production, errors occurred in the idle event handler, not in the draw() function.

I can not find the condition, but I can reproduce this error in local env.
It looks like below.

2018-02-19 19 56 31

fix "Cannot read property 'fromLatLngToDivPixel' of undefined" GoogleMapReact#257
@jeremymarc

Copy link
Copy Markdown

+1

1 similar comment
@Stosiu

Stosiu commented Feb 22, 2018

Copy link
Copy Markdown

+1

@loris

loris commented Feb 22, 2018

Copy link
Copy Markdown

+1, same error happening in production

@itsmichaeldiego itsmichaeldiego left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this change but we need to keep in mind that there are some binding events under your return; that might get broken, so we should skip only the code that relates to div or overlay

@fmy

fmy commented Feb 23, 2018

Copy link
Copy Markdown
Contributor Author

@itsmichaeldiego I addressed your point. please review it!

@itsmichaeldiego itsmichaeldiego left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@itsmichaeldiego
itsmichaeldiego merged commit 4a07176 into GoogleMapReact:master Feb 23, 2018
@itsmichaeldiego

Copy link
Copy Markdown
Member

@fmy @loris @Stosiu @jeremymarc Merged and published in version 0.32.0.

@lock

lock Bot commented Dec 1, 2019

Copy link
Copy Markdown

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock Bot locked as resolved and limited conversation to collaborators Dec 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants