Skip to content

Add fullscreen check for Internet explorer 11 - #485

Merged
itsmichaeldiego merged 3 commits into
GoogleMapReact:masterfrom
omladek:patch-1
Jan 4, 2018
Merged

itsmichaeldiego merged 3 commits into
GoogleMapReact:masterfrom
omladek:patch-1

Conversation

@omladek

@omladek omladek commented Dec 22, 2017

Copy link
Copy Markdown
Contributor

Fixing marker position in Internet Explorer 11 in fullscreen mode.
Fixing: #484

Fixing marker position in Internet Explorer 11 in fullscreen mode.
Fixing: GoogleMapReact#484

@itsmichaeldiego itsmichaeldiego left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This if is getting really big, could we create a function called isFullScreen and move all this logic there to make it cleaner? Thanks.

@omladek

omladek commented Jan 3, 2018

Copy link
Copy Markdown
Contributor Author

Code is moved to function isFullScreen.

@emilpalsson

Copy link
Copy Markdown
Contributor

Great job guys, would love to see this merged as well to complete #452. Thanks!

@nicolasdelfino nicolasdelfino left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, go for it

@itsmichaeldiego
itsmichaeldiego merged commit e47d955 into GoogleMapReact:master Jan 4, 2018
@itsmichaeldiego

Copy link
Copy Markdown
Member

@omladek Good job, thanks!

@lock

lock Bot commented Dec 1, 2019

Copy link
Copy Markdown

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock Bot locked as resolved and limited conversation to collaborators Dec 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants