Skip to content

Renamed pointer-geometry dependency to @mapbox/pointer-geometry - #437

Closed
eko wants to merge 1 commit into
GoogleMapReact:masterfrom
eko:fixed-pointer-geometry
Closed

eko wants to merge 1 commit into
GoogleMapReact:masterfrom
eko:fixed-pointer-geometry

Conversation

@eko

@eko eko commented Aug 21, 2017

Copy link
Copy Markdown

Hello,

This dependency has been renamed so when running npm install, we get:

$ npm install

npm WARN deprecated point-geometry@0.0.0: This module has moved: please install @mapbox/point-geometry instead

Thank you

@Horat1us

Horat1us commented Sep 4, 2017

Copy link
Copy Markdown

+1 Why not to merge this PR?

@rmacqueen

Copy link
Copy Markdown

Agreed, please merge. Warnings are quite annoying and is easy fix

@istarkov

istarkov commented Sep 9, 2017

Copy link
Copy Markdown
Member

has anyone checked releases log of pointer geometry, I have no time to check this

@Horat1us

Horat1us commented Sep 9, 2017

Copy link
Copy Markdown

They just add some methods:

https://github.com/mapbox/point-geometry/blob/master/HISTORY.md

@eko

eko commented Sep 9, 2017

Copy link
Copy Markdown
Author

+1, I don't see any BC break

@exomnius

exomnius commented Oct 9, 2017

Copy link
Copy Markdown
Contributor

Seems ok. Please merge this for next version release.

@itsmichaeldiego

Copy link
Copy Markdown
Member

@eko Thanks for your PR, this changes have been handled in #462

@lock

lock Bot commented Dec 1, 2019

Copy link
Copy Markdown

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock Bot locked as resolved and limited conversation to collaborators Dec 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants