Skip to content

Conversation

@duggelz
Copy link
Contributor

@duggelz duggelz commented Aug 23, 2017

Local double-build patch was removed, since it has been applied upstream to 3.5.4.

net-tools \
netbase \
python3 \
quilt \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why remove this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed the last patch that uses quilt. We'll add it back in if we add another local patch.

Actually, quilt is pretty annoying, in that it has a fatal error if you give it a list of patches that happens to be empty. Otherwise I would have left all the quilt code intact.

Copy link
Member

@liyanhui1228 liyanhui1228 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@duggelz duggelz merged commit bd90681 into master Aug 23, 2017
@duggelz duggelz deleted the dgreiman/py354 branch August 23, 2017 22:15
duggelz pushed a commit that referenced this pull request Aug 24, 2017
The 'patches' directory was implicitly removed in
#142 when we
deleted the last file in it.  However, this wasn't found in testing
because my local client still had a patches directory.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants