make_iap_request: Replace base URL with client ID#979
Merged
theacodes merged 2 commits intoGoogleCloudPlatform:masterfrom Jun 23, 2017
matthewg:patch-2
Merged
make_iap_request: Replace base URL with client ID#979theacodes merged 2 commits intoGoogleCloudPlatform:masterfrom matthewg:patch-2
theacodes merged 2 commits intoGoogleCloudPlatform:masterfrom
matthewg:patch-2
Conversation
Client ID is the preferred thing to use for the aud claim. --msachs@, IAP TLM
googlebot
added
the
cla: yes
theacodes
approved these changes
Jun 12, 2017
Contributor
Author
|
I've now updated the test as well. (I got the client ID by navigating to https://gcp-devrel-iap-reflect.appspot.com/ -- the client ID can be pulled from the resulting redirect URL.) I don't have permission to merge, would you mind doing it? |
theacodes
approved these changes
Jun 23, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Client ID is the preferred thing to use for the aud claim.
--msachs@, IAP TLM