Skip to content

testing(bigquery): skip all datalab tests #9467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
leahecole merged 3 commits into from
Apr 3, 2023
Merged

testing(bigquery): skip all datalab tests #9467

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d73dfd4
testing(bigquery): skip all datalab tests
shollyman Apr 3, 2023
cce9d2f
one more skip
shollyman Apr 3, 2023
55a558b
lint
shollyman Apr 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions bigquery/datalab-migration/samples_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,7 @@ def test_datalab_query_magic(ipython_interactive):
assert len(df) == 100


@pytest.mark.skip("datalab is deprecated, remove tests in sept 2023")
def test_client_library_query_magic(ipython_interactive):
import pandas

Expand All @@ -106,6 +107,7 @@ def test_client_library_query_magic(ipython_interactive):
assert len(df) == 100


@pytest.mark.skip("datalab is deprecated, remove tests in sept 2023")
def test_datalab_query_magic_results_variable(ipython_interactive):
ip = _set_up_ipython('google.datalab.kernel')

Expand Down Expand Up @@ -155,6 +157,7 @@ def test_client_library_query_magic_results_variable(ipython_interactive):
ip.user_ns.pop(variable_name) # clean up variable


@pytest.mark.skip("datalab is deprecated, remove tests in sept 2023")
def test_datalab_list_tables_magic(ipython_interactive):
ip = _set_up_ipython('google.datalab.kernel')

Expand All @@ -170,6 +173,7 @@ def test_datalab_list_tables_magic(ipython_interactive):
assert "shakespeare" in html_element.data


@pytest.mark.skip("datalab is deprecated, remove tests in sept 2023")
def test_datalab_query():
# [START bigquery_migration_datalab_query]
import google.datalab.bigquery as bq
Expand Down Expand Up @@ -201,6 +205,7 @@ def test_client_library_query():
assert len(df) == 100


@pytest.mark.skip("datalab is deprecated, remove tests in sept 2023")
def test_datalab_load_table_from_gcs_csv(to_delete):
# [START bigquery_migration_datalab_load_table_from_gcs_csv]
import google.datalab.bigquery as bq
Expand Down Expand Up @@ -269,6 +274,7 @@ def test_client_library_load_table_from_gcs_csv(to_delete):
assert table.num_rows == 50


@pytest.mark.skip("datalab is deprecated, remove tests in sept 2023")
def test_datalab_load_table_from_dataframe(to_delete):
""" Wrap test with retries to handle transient errors """
@Retry()
Expand Down