Skip to content

chore(functions/v2/firebase/upper-firestore): Make upper firestore sample gcf gen 2 compatible#9412

Merged
kenneth-rosario merged 1 commit into
GoogleCloudPlatform:mainfrom
kenneth-rosario:kennethrosario/functions_cloudevent_firebase_reactive
Apr 17, 2023
Merged

chore(functions/v2/firebase/upper-firestore): Make upper firestore sample gcf gen 2 compatible#9412
kenneth-rosario merged 1 commit into
GoogleCloudPlatform:mainfrom
kenneth-rosario:kennethrosario/functions_cloudevent_firebase_reactive

Conversation

@kenneth-rosario

Copy link
Copy Markdown

No description provided.

@product-auto-label product-auto-label Bot added api: cloudfunctions Issues related to the Cloud Run functions API. samples Issues that are directly related to samples. labels Mar 30, 2023
@kenneth-rosario kenneth-rosario force-pushed the kennethrosario/functions_cloudevent_firebase_reactive branch 3 times, most recently from f0db7bc to e61750b Compare March 30, 2023 04:25
@kenneth-rosario kenneth-rosario marked this pull request as ready for review March 31, 2023 01:18
@kenneth-rosario kenneth-rosario requested review from a team as code owners March 31, 2023 01:18
@snippet-bot

snippet-bot Bot commented Mar 31, 2023

Copy link
Copy Markdown

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@kenneth-rosario kenneth-rosario force-pushed the kennethrosario/functions_cloudevent_firebase_reactive branch 2 times, most recently from dbecb36 to 2302117 Compare March 31, 2023 18:19
@kweinmeister kweinmeister changed the title chore(functions/v2/firebase/upper-firestore): Make upper firestore sample gcf gen 2 comaptible chore(functions/v2/firebase/upper-firestore): Make upper firestore sample gcf gen 2 compatible Apr 9, 2023
@kweinmeister kweinmeister requested a review from a team as a code owner April 16, 2023 23:14
Comment thread functions/v2/firebase/upper-firestore/main.py Outdated
@kenneth-rosario kenneth-rosario force-pushed the kennethrosario/functions_cloudevent_firebase_reactive branch from 5050279 to d7b5986 Compare April 17, 2023 20:00

@garethgeorge garethgeorge left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kenneth-rosario kenneth-rosario merged commit fdfd89f into GoogleCloudPlatform:main Apr 17, 2023
@kenneth-rosario kenneth-rosario deleted the kennethrosario/functions_cloudevent_firebase_reactive branch April 17, 2023 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: cloudfunctions Issues related to the Cloud Run functions API. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants