Skip to content

fix: migrate run markdown-preview sample to bleach 6#9057

Merged
engelke merged 3 commits into
mainfrom
bleach
Feb 2, 2023
Merged

fix: migrate run markdown-preview sample to bleach 6#9057
engelke merged 3 commits into
mainfrom
bleach

Conversation

@kweinmeister

Copy link
Copy Markdown
Contributor

The list of allowed tags in bleach 6 is now a frozenset rather than a list. The existing logic tries to append an extra element, which now fails. This PR creates a new list from the frozenset instead.

@product-auto-label product-auto-label Bot added samples Issues that are directly related to samples. api: run Issues related to the Cloud Run API. labels Jan 27, 2023
@kweinmeister kweinmeister marked this pull request as ready for review January 28, 2023 00:48
@kweinmeister kweinmeister requested review from a team as code owners January 28, 2023 00:48
@kweinmeister kweinmeister added the automerge Merge the pull request once unit tests and other checks pass. label Feb 1, 2023
@gcf-merge-on-green

Copy link
Copy Markdown
Contributor

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green Bot removed the automerge Merge the pull request once unit tests and other checks pass. label Feb 1, 2023
@kweinmeister kweinmeister added the automerge Merge the pull request once unit tests and other checks pass. label Feb 2, 2023
@engelke engelke merged commit bfe8970 into main Feb 2, 2023
@engelke engelke deleted the bleach branch February 2, 2023 19:22
@gcf-merge-on-green gcf-merge-on-green Bot removed the automerge Merge the pull request once unit tests and other checks pass. label Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: run Issues related to the Cloud Run API. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants