Skip to content

people and planet tf bump#8359

Merged
davidcavazos merged 7 commits into
mainfrom
8310_2
Oct 7, 2022
Merged

people and planet tf bump#8359
davidcavazos merged 7 commits into
mainfrom
8310_2

Conversation

@leahecole

Copy link
Copy Markdown
Collaborator

split #8310 into three PRs

@leahecole leahecole requested review from a team and davidcavazos as code owners September 27, 2022 14:47
@product-auto-label product-auto-label Bot added the samples Issues that are directly related to samples. label Sep 27, 2022

@davidcavazos davidcavazos left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These should all work, LGTM

@leahecole

Copy link
Copy Markdown
Collaborator Author

@davidcavazos it seems like these are the ones that are causing timeouts. Do you have any suspicions for which one might be the culprit or should I just split these up even further to see what happens? One thing I do notice is that some of the TF versions have a bigger bump than others - not sure if going to a new minor version could be causing problems. I do believe this TF version supports python 3.7 and 3.8 though and even if it didn't that wouldn't timeout

@davidcavazos

Copy link
Copy Markdown

This is a great question! TensorFlow releases tend to be pretty large, and due to the way that pip resolves dependencies, it can take a long time to resolve dependencies without a constraints file. I know Dataflow comes with a pre-installed version of TensorFlow. I suspect we're maybe updating to a more recent version which causes delays in the workers setup. Splitting each PPAI sample into their own should help. However! We're updating the land cover sample (#8365) with an already up-to-date version of TF so you can safely skip that :)

@ivanmkc ivanmkc left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a straightforwards refactor.

LGTM

@davidcavazos davidcavazos merged commit 26fd536 into main Oct 7, 2022
@davidcavazos davidcavazos deleted the 8310_2 branch October 7, 2022 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants