Skip to content

BigQuery - REST samples for adding labels.#764

Merged
theacodes merged 1 commit intomasterfrom
tswast-bq-labels
Jan 20, 2017
Merged

BigQuery - REST samples for adding labels.#764
theacodes merged 1 commit intomasterfrom
tswast-bq-labels

Conversation

@tswast
Copy link
Copy Markdown
Contributor

@tswast tswast commented Jan 20, 2017

@tswast tswast requested a review from theacodes January 20, 2017 20:21
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 20, 2017
@tswast
Copy link
Copy Markdown
Contributor Author

tswast commented Jan 20, 2017

I'm looking into the Travis failure.

{\n  "error" : "invalid_scope",\n  "error_description" : "Empty or missing scope not allowed."\n}

Strange that it worked on my machine. I guess maybe because Travis is using a service account and I was using gcloud credentials?

@tswast
Copy link
Copy Markdown
Contributor Author

tswast commented Jan 20, 2017

I'll add a scope argument to the google.auth.defaults() call.

@theacodes
Copy link
Copy Markdown
Contributor

I'll add a scope argument to the google.auth.defaults() call.

yep, that should do it.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use response.raise_for_status().

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

put session in the auth section (two lines above)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make sense to combine these into one single file named labels?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it would. Combined.

@theacodes theacodes merged commit 1822e4e into master Jan 20, 2017
@theacodes theacodes deleted the tswast-bq-labels branch January 20, 2017 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bigquery cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants