ci: do not run 3.6 tests by default #7409
Conversation
busunkim96
requested review from
a team,
alixhami,
anguillanneuf,
bradmiro,
davidcavazos,
hongalex,
leahecole and
shollyman
as code owners
product-auto-label
bot
added
the
samples
anguillanneuf
left a comment
anguillanneuf
left a comment
There was a problem hiding this comment.
Looks good for Pub/Sub.
|
LGTM for data science onramp |
| TEST_CONFIG_OVERRIDE = { | ||
| # You can opt out from the test for specific Python versions. | ||
| "ignored_versions": ["2.7", "3.8", "3.9", "3.10"], | ||
| "ignored_versions": ["2.7", "3.6", "3.8", "3.9", "3.10"], |
There was a problem hiding this comment.
@alecglassford We have you listed in CODEOWNERS for ml_engine, would you know if this change is OK to take?
There was a problem hiding this comment.
@busunkim96 Hi! I no longer work at the company, so I'm not a good person to answer this question. (You should probably also remove me from CODEOWNERS; sorry that I didn't think to do this before I left!)
notebooks/noxfile_config.py
Outdated
| # You can opt out from the test for specific Python versions. | ||
| # Skipping for Python 3.9 due to pyarrow compilation failure. | ||
| "ignored_versions": ["2.7", "3.9"], | ||
| "ignored_versions": ["2.7", "3.6", "3.9"], |
There was a problem hiding this comment.
This directory doesn't seem to have any .py files, maybe the noxfile.py and noxfile_config.py should be deleted? https://github.com/GoogleCloudPlatform/python-docs-samples/tree/main/notebooks
There was a problem hiding this comment.
I think it's fine to remove them! We don't currently use nox on notebooks - we should be able to do CI testing on notebooks once we've added the testing pipeline to this repo. LGTM
| TEST_CONFIG_OVERRIDE = { | ||
| # You can opt out from the test for specific Python versions. | ||
| "ignored_versions": ["2.7", "3.8", "3.9", "3.10"], | ||
| "ignored_versions": ["2.7", "3.6", "3.8", "3.9", "3.10"], |
.github/CODEOWNERS
Outdated
| /media/**/*.py @irataxy @GoogleCloudPlatform/python-samples-owners | ||
| /memorystore/**/*.py @GoogleCloudPlatform/python-samples-owners | ||
| /ml_engine/**/*.py @alecglassford @GoogleCloudPlatform/python-samples-owners | ||
| /ml_engine/**/*.py @ivanmkc @GoogleCloudPlatform/python-samples-owners |
There was a problem hiding this comment.
@nicain could you take this change onto a separate PR?
|
LGTM for Dataflow related samples. |
|
@engelke does this look ok for appengine? |
|
@nicain Could you re-review this PR? |
Copied from GoogleCloudPlatform/python-docs-samples#7409 Co-authored-by: Anna Cocuzzo <63511057+acocuzzo@users.noreply.github.com>
11 participants
Python 3.6 went End-of-Life in December. This PR adds 3.6 to the default
ignored_versionslist innoxfile-template.py,noxfile.pyandnoxfile_config.pyfiles.If we need to run 3.6 in any directories, we can use a noxfile_config that doesn't have 3.6 in the ignore list.