doc: Update env variable mentioned in Authoring Guide #7406
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The correct value to be changed in `testing/test-env.sh` is `GOOGLE_CLOUD_PROJECT` instead of `GCLOUD_PROJECT`. Source: https://github.com/GoogleCloudPlatform/python-docs-samples/blob/1d6736bd49778b2440e348890ec444d785c4fb60/testing/test-env.tmpl.sh#L16
product-auto-label
bot
added
the
samples
busunkim96
approved these changes
Jan 28, 2022
Contributor
busunkim96
left a comment
busunkim96
left a comment
There was a problem hiding this comment.
Good catch! Thank you for updating this 🙏
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The correct value to be changed in
testing/test-env.shisGOOGLE_CLOUD_PROJECTinstead of
GCLOUD_PROJECT.Source:
python-docs-samples/testing/test-env.tmpl.sh
Line 16 in 1d6736b
Description
Fixes #
Note: It's a good idea to open an issue first for discussion.
Checklist
nox -s py-3.6(see Test Environment Setup)nox -s lint(see Test Environment Setup)