feat(pubsublite): attributes field in sink example #7405
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
api: pubsublite
busunkim96
approved these changes
Jan 28, 2022
| # |-- key: binary (nullable = false) | ||
| # |-- data: binary (nullable = true) | ||
| # |-- event_timestamp: timestamp (nullable = true) | ||
| # |-- attributes: map (nullable = false) |
There was a problem hiding this comment.
our guide and everywhere actually specifies attributes is nullable.
There was a problem hiding this comment.
but our code doesn't really check since they are compatible ie our codebase is ok with nullable, I think it's fine.
Member
Author
There was a problem hiding this comment.
@jiangmichaellll Yes, all the fields can be nulls. It's just we are printing out of the dataframe created by the code above.
jiangmichaellll
approved these changes
Jan 28, 2022
anguillanneuf
force-pushed
the
pubsublite-spark-attributes
branch
3 times, most recently
from
a3b327a to
6974675
Compare
hongalex
approved these changes
Jan 28, 2022
anguillanneuf
force-pushed
the
pubsublite-spark-attributes
branch
from
6974675 to
32a24fb
Compare
This was referenced Jan 28, 2022
anguillanneuf
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because this bug was fixed in the Pub/Sub Lite Spark connector googleapis/java-pubsublite-spark#261 with a new release, we are now able to write to Pub/Sub Lite with an
attributesfield.Updating the sample to show how to do that.