fix: remove vulnerable Pillow versions #7367
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dandhlee
added
the
do not merge
product-auto-label
bot
added
the
samples
davidcavazos
approved these changes
Jan 13, 2022
davidcavazos
left a comment
davidcavazos
left a comment
There was a problem hiding this comment.
LGTM, I'm okay with dropping 3.6
dandhlee
removed
the
do not merge
parthea
approved these changes
Jan 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If we're not using Pillow V9, it will be vulnerable to moderate/high severity issues. Pillow V9 requires Python version to be higher than 3.6.
appengine/scipyanddataflow/tensorflow-landsatboth does not require using Python3.6 and below, so I've removed their references altogether.For
ppai/image-classification: @davidcavazos it seems that the Pillow code used inimage-classificationdoes not contain any of the vulnerabilities mentioned in the issue. Perhaps just to be on the safe side I'm proposing that we remove 3.6 support for it (it's reached end of life too), or we could still keep it open for 3.6. Which side would you lean towards on?Fixes #7366.
Checklist
nox -s py-3.6(see Test Environment Setup)nox -s lint(see Test Environment Setup)