Skip to content

feat: add code sample and test for concatenating two input videos #7197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
busunkim96 merged 14 commits into from
Jan 13, 2022
Merged

feat: add code sample and test for concatenating two input videos #7197

busunkim96 merged 14 commits into from
Jan 13, 2022

Conversation

@irataxy
Copy link
Contributor

@irataxy irataxy commented Dec 4, 2021

Description

Fixes 197546828

Note: It's a good idea to open an issue first for discussion.

Checklist

@irataxy irataxy requested a review from a team as a code owner December 4, 2021 18:33
@snippet-bot
Copy link

snippet-bot bot commented Dec 4, 2021 •
edited
Loading

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Dec 4, 2021
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Dec 4, 2021
@irataxy irataxy added kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed kokoro:run Add this label to force Kokoro to re-run the tests. labels Dec 6, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 6, 2021
@leahecole leahecole added the blunderbuss: assign Instruct blunderbuss to assign someone label Dec 8, 2021
@blunderbuss-gcf blunderbuss-gcf bot removed the blunderbuss: assign Instruct blunderbuss to assign someone label Dec 8, 2021
nicain
nicain requested changes Jan 7, 2022
View reviewed changes
@irataxy irataxy requested a review from nicain January 8, 2022 00:12
nicain
nicain approved these changes Jan 13, 2022
View reviewed changes
Copy link
Contributor

@nicain nicain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

busunkim96
busunkim96 reviewed Jan 13, 2022
View reviewed changes
@nicain nicain requested a review from busunkim96 January 13, 2022 21:49
busunkim96
busunkim96 approved these changes Jan 13, 2022
View reviewed changes
Copy link
Contributor

@busunkim96 busunkim96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@busunkim96 busunkim96 merged commit 9b1a539 into GoogleCloudPlatform:main Jan 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nicain nicain nicain approved these changes

+1 more reviewer

@busunkim96 busunkim96 busunkim96 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@nicain nicain

Labels

cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@irataxy @nicain @busunkim96 @leahecole @kokoro-team