Conversation
tswast
added
the
do not merge
googlebot
added
the
cla: yes
There was a problem hiding this comment.
Can you do two separate sample functions instead of one?
There was a problem hiding this comment.
Done.
Yes, splitting into separate functions should make it a little easier to talk about in the docs I write for this, too.
theacodes
left a comment
theacodes
left a comment
There was a problem hiding this comment.
Do you need both sync and async? We already have a comprehensive sample on async querying, is it worthwhile to duplicate here or would a comment mentioning that you could also do this async work?
| print_results(query_job.results()) | ||
|
|
||
|
|
||
| def main(use_named_params=False, corpus='romeoandjuliet', min_word_count=100): |
There was a problem hiding this comment.
No main function, please.
|
@tswast a new bigquery version has been released. |
tswast
changed the title
tswast
removed
the
do not merge
|
Thanks. I've updated the package and deleted the async sample. You're right. They are so similar, it's probably not worth including both. |
There was a problem hiding this comment.
Import modules, not names.
Available in latest version of google-cloud-bigquery (0.22.0), so upgrades the requirement, too.
…tform/python-docs-samples#699) Available in latest version of google-cloud-bigquery (0.22.0), so upgrades the requirement, too.
…tform/python-docs-samples#699) Available in latest version of google-cloud-bigquery (0.22.0), so upgrades the requirement, too.
…on-docs-samples#699) Available in latest version of google-cloud-bigquery (0.22.0), so upgrades the requirement, too.
3 participants
This query syntax is supported in the not-yet-released version of google-cloud-python in googleapis/google-cloud-python#2776.
I've added the do not merge label, since we should wait for the next google-cloud-python release, but the sample should be ready to review.