Merged
Conversation
Change-Id: Ica205635543f07cc1b8f5a619ab58576fed5da30
theacodes
added
the
do not merge
googlebot
added
the
cla: yes
theacodes
removed
the
do not merge
Contributor
Author
|
This refactor isolates every samples' run from all others, each sample now has an isolated virtualenv. This will make complete builds slower, but incremental builds shouldn't suffer. This will also make it easier for us to add user journey tests. |
waprin
reviewed
Nov 29, 2016
| This is used when running the linter to insure that import order is | ||
| properly checked. | ||
| """ | ||
| return [ |
Contributor
There was a problem hiding this comment.
suggest breaking out nested comprehension into two lines, slightly hard to follow
waprin
reviewed
Nov 29, 2016
nox.py
Outdated
| requirements_files.append('./testing/requirements-dev.in') | ||
| print('The following samples do not have tests:') | ||
| for sample in set(ALL_SAMPLE_DIRECTORIES) - set(ALL_TESTED_SAMPLES): | ||
| print('*', sample) |
Contributor
There was a problem hiding this comment.
This is intentional? Expected something like print('*{}').format(sample) .
Contributor
|
lgtm |
Change-Id: I06a4ec7a542eb88ca367fd1936fa499aac4045ff
Contributor
Author
|
Merging, can address other comments in follow-ups. |
jerjou
reviewed
Nov 29, 2016
| export GOOGLE_APPLICATION_CREDENTIALS=${TRAVIS_BUILD_DIR}/testing/service-account.json | ||
| export GOOGLE_CLIENT_SECRETS=${TRAVIS_BUILD_DIR}/testing/client-secrets.json | ||
| nox --stop-on-first-error -s lint travis; | ||
| nox --stop-on-first-error -s lint gae py35; |
Contributor
Author
There was a problem hiding this comment.
We weren't before either.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.