Skip to content

ppai: add more descriptions and links to videos#6783

Merged
davidcavazos merged 9 commits into
GoogleCloudPlatform:masterfrom
davidcavazos:ppai-timeseries-classification
Oct 6, 2021
Merged

ppai: add more descriptions and links to videos#6783
davidcavazos merged 9 commits into
GoogleCloudPlatform:masterfrom
davidcavazos:ppai-timeseries-classification

Conversation

@davidcavazos

Copy link
Copy Markdown

Description

Add more descriptions into the READMEs and add links to their respective video episodes.

Checklist

@davidcavazos davidcavazos requested a review from a team as a code owner October 1, 2021 17:50
@product-auto-label product-auto-label Bot added the samples Issues that are directly related to samples. label Oct 1, 2021
@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 1, 2021
@davidcavazos davidcavazos added the blunderbuss: assign Instruct blunderbuss to assign someone label Oct 1, 2021
@blunderbuss-gcf blunderbuss-gcf Bot removed the blunderbuss: assign Instruct blunderbuss to assign someone label Oct 1, 2021
@davidcavazos

Copy link
Copy Markdown
Author

Tests are passing (except for Python 3.10 even though it's disabled).

@dandhlee dandhlee left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one minor comment below!

Comment thread people-and-planet-ai/README.md Outdated
Comment thread people-and-planet-ai/image-classification/noxfile_config.py Outdated
@davidcavazos davidcavazos added the automerge Merge the pull request once unit tests and other checks pass. label Oct 5, 2021
@davidcavazos

Copy link
Copy Markdown
Author

The 3.10 failure is expected as that job is not yet fully configured, see #6762.

@dandhlee

dandhlee commented Oct 5, 2021

Copy link
Copy Markdown
Collaborator

@davidcavazos 3.8 seemed to have failed, could you take a look and see if it's an actual test error?

@davidcavazos

Copy link
Copy Markdown
Author

#6799 might solve the issue

@davidcavazos

Copy link
Copy Markdown
Author
Resources are insufficient in region: us-central1. Please try a different region. If you use K80, please consider using P100 or V100 instead.

@dandhlee

dandhlee commented Oct 5, 2021

Copy link
Copy Markdown
Collaborator

Aiya 😂

@dandhlee dandhlee removed the automerge Merge the pull request once unit tests and other checks pass. label Oct 5, 2021
@davidcavazos davidcavazos added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 6, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 6, 2021
@davidcavazos davidcavazos merged commit 4064308 into GoogleCloudPlatform:master Oct 6, 2021
@davidcavazos davidcavazos deleted the ppai-timeseries-classification branch October 6, 2021 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants