Conversation
googlebot
added
the
cla: yes
theacodes
approved these changes
Oct 19, 2016
Contributor
There was a problem hiding this comment.
This doesn't seem to be used, remove it?
Contributor
Author
|
@dpebot would you mind merging when travis approves? |
jerjou
added
the
automerge
added 2 commits
October 20, 2016 12:10
Contributor
Author
|
FYI added a commit to fix the style errors that are breaking the build. |
The doc that depends on this is undergoing a rewrite that obviates the need for this file. Plus, checking for "null" seems unnecessary, and there are a bunch of style things that aren't passing our linter.
Contributor
Author
|
FYI removed a file that also had style errors (and a dubious null check). Also, a rewrite of the doc that uses it may make the file obsolete (so not worth trying to fix it). If it turns out to still be needed, we can open another PR to re-add it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.