Skip to content

Conversation

@dandhlee
Copy link
Collaborator

Description

Fixing a minor typo on noxfile configs across Samples

Note: It's a good idea to open an issue first for discussion.

Checklist

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Apr 24, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Apr 24, 2021
Copy link
Contributor

@engelke engelke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dandhlee dandhlee added the automerge Merge the pull request once unit tests and other checks pass. label Apr 24, 2021
@gcf-merge-on-green
Copy link
Contributor

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Apr 24, 2021
@leahecole
Copy link
Collaborator

Admin merging - the failures are unrelated to this typo and are an already tracked bug

@leahecole leahecole merged commit 2cf2bd1 into master Apr 26, 2021
@leahecole leahecole deleted the fix_typo branch April 26, 2021 19:01
@dandhlee
Copy link
Collaborator Author

Thanks Leah!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants