Skip to content

fix: update eventarc storage name #5373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gcf-merge-on-green merged 2 commits into from
Feb 17, 2021
Merged

fix: update eventarc storage name #5373

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
57ba7aa
fix: update eventarc storage name
grant Feb 17, 2021
ccc6a2e
Merge branch 'master' into grant_eventarc_cal_storage_name
gcf-merge-on-green[bot] Feb 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions eventarc/audit-storage/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,8 @@ def index():
# Example: "storage.googleapis.com/projects/_/buckets/my-bucket"
bucket = request.headers.get('ce-subject')

print(f"Detected change in GCS bucket: {bucket}")
return (f"Detected change in GCS bucket: {bucket}", 200)
print(f"Detected change in Cloud Storage bucket: {bucket}")
return (f"Detected change in Cloud Storage bucket: {bucket}", 200)
# [END eventarc_gcs_handler]


Expand Down
2 changes: 1 addition & 1 deletion eventarc/audit-storage/main_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,4 +42,4 @@ def test_endpoint(client, capsys):
assert r.status_code == 200

out, _ = capsys.readouterr()
assert f"Detected change in GCS bucket: {test_headers['Ce-Subject']}" in out
assert f"Detected change in Cloud Storage bucket: {test_headers['Ce-Subject']}" in out