new tutorial: deployment previews#4979
Conversation
moves https://github.com/GoogleCloudPlatform/cloud-run-deployment-previews into the python-docs-samples, where similar tutorial code lives.
|
Here is the summary of changes. You added 5 region tags.
This comment is generated by snippet-bot.
|
google-cla
Bot
added
the
cla: yes
product-auto-label
Bot
added
the
samples
|
Typehinting based on comments in my other active PR. Using |
averikitsch
left a comment
averikitsch
left a comment
There was a problem hiding this comment.
I did a quicker review of this. @dinagraves should probably review too
| @@ -0,0 +1,5 @@ | |||
| These configuations aren't used by this repo itself, but are configurations required to use the code in this repo. | |||
There was a problem hiding this comment.
Add a title to the ReadMe maybe # Deployment Preview Cloud Build Configuration. (we use "nit" to describe likes but not must haves)
…amples into deployment-previews
|
Lint will succeed once the noxfile changes in 4869 land and can be rebased into this branch |
averikitsch
left a comment
averikitsch
left a comment
There was a problem hiding this comment.
Sorry, a few more small comments
busunkim96
left a comment
busunkim96
left a comment
There was a problem hiding this comment.
Python bits look good to me. 👍
…amples into deployment-previews
|
After merging the noxfile-template changes in another PR, this is now green 🥳 |
averikitsch
left a comment
averikitsch
left a comment
There was a problem hiding this comment.
Approving but would like to see updates to the Dockerfile
leahecole
added
the
automerge
gcf-merge-on-green
Bot
removed
the
automerge
5 participants
moves
https://github.com/GoogleCloudPlatform/cloud-run-deployment-previews
into the python-docs-samples, where similar tutorial code lives.
internal cl/339786037
Checklist
nox -s py-3.6(see Test Environment Setup)nox -s lint(see Test Environment Setup)