docs: readme formatting#4938
Merged
Merged
Conversation
Signed-off-by: Grant Timmerman <timmerman+devrel@google.com>
google-cla
Bot
added
the
cla: yes
Signed-off-by: Grant Timmerman <timmerman+devrel@google.com>
grant
force-pushed
the
grant_readme_touchup
branch
from
24977f0 to
6400a11
Compare
leahecole
reviewed
Nov 4, 2020
leahecole
left a comment
leahecole
left a comment
Collaborator
There was a problem hiding this comment.
LGTM - just want to double check with the other @GoogleCloudPlatform/python-samples-owners - this isn't a generated file, right? (I'm mostly certain it's not generated in this repo) and as long as it's not, I'm cool with it. Thank you for doing this, @grant !
busunkim96
reviewed
Nov 5, 2020
Contributor
I can confirm this one isn't generated. |
Co-authored-by: Bu Sun Kim <8822365+busunkim96@users.noreply.github.com>
Co-authored-by: Bu Sun Kim <8822365+busunkim96@users.noreply.github.com>
engelke
reviewed
Nov 5, 2020
Contributor
Author
|
Please merge when approved, or request changes. :) |
leahecole
approved these changes
Nov 5, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #4837