Skip to content

feat(spanner): add samples for NUMERIC type#4643

Merged
larkee merged 8 commits into
GoogleCloudPlatform:masterfrom
larkee:spanner_numeric_samples
Sep 22, 2020
Merged

feat(spanner): add samples for NUMERIC type#4643
larkee merged 8 commits into
GoogleCloudPlatform:masterfrom
larkee:spanner_numeric_samples

Conversation

@larkee

@larkee larkee commented Sep 8, 2020

Copy link
Copy Markdown
Contributor

Adds samples showing how to use the NUMERIC type in Cloud Spanner.

@larkee larkee added the api: spanner Issues related to the Spanner API. label Sep 8, 2020
@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 8, 2020
@product-auto-label product-auto-label Bot added the samples Issues that are directly related to samples. label Sep 8, 2020
@larkee larkee force-pushed the spanner_numeric_samples branch from b5040eb to aac6ab3 Compare September 17, 2020 03:40
@larkee larkee changed the title docs(spanner): add samples for NUMERIC type feat(spanner): add samples for NUMERIC type Sep 18, 2020
@larkee larkee marked this pull request as ready for review September 18, 2020 13:59
@larkee larkee requested a review from a team as a code owner September 18, 2020 13:59
Comment thread spanner/cloud-client/snippets.py

@hengfengli hengfengli left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@thiagotnunes thiagotnunes left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@larkee larkee merged commit 31ee2bd into GoogleCloudPlatform:master Sep 22, 2020
larkee added a commit to larkee/python-spanner that referenced this pull request Sep 24, 2020
…form/python-docs-samples#4643)

* feat(spanner) add samples for NUMERIC support

* fix: fix typo

* test: reorder tests to ensure required samples run first

* fix: fix another typo

* test: remove unneeded asserts

Co-authored-by: larkee <larkee@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: spanner Issues related to the Spanner API. cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants