Conversation
googlebot
added
the
cla: yes
added 2 commits
August 17, 2016 14:58
Change-Id: I6bf9a8acb9ba7d067b3095b5857094cbc322ff58
Change-Id: Ie0df6747050035b2ef5f937951d5ff955073e6d4
Change-Id: I0d3bdf3d6842339d04abc4ee6ddb26b8f44be3e5
| row.set_cell( | ||
| column_family_id, | ||
| column_id.encode('utf-8'), | ||
| column_id, |
Contributor
There was a problem hiding this comment.
Should this have some six magic for python2 compatibility?
Contributor
There was a problem hiding this comment.
I think Jon is just fixing a double encode? I think in general if you want Python strings as bytes, do the encode, no six necessary.
Contributor
There was a problem hiding this comment.
Ah cool. I totally didn't look at the context ^_^;
Contributor
Author
There was a problem hiding this comment.
Yeah fixing a double encode. No idea how this worked on py2.7 other than luck.
Contributor
|
hooray. code lgtm. running it locally if you want to wait for that but I'm guessing any problems there will be doc issues anyway. |
appengine/standard/conftest.py
Outdated
|
|
||
|
|
||
| def pytest_ignore_collect(path, config): | ||
| """Skip App Engine tests in python 3 and if no SDK is available.""" |
Contributor
|
LGTM if LGTTravis |
Change-Id: I02a53961b6411247ef06d84dad7b533cb97d89f7
Contributor
Author
|
@dpebot merge when travis passes |
Collaborator
|
Okay! I'll merge when all statuses are green. |
dpebot
added
the
automerge
8 tasks
telpirion
pushed a commit
that referenced
this pull request
Jan 13, 2023
Co-authored-by: AJ Morozoff <amorozoff@google.com> Co-authored-by: Anthonios Partheniou <partheniou@google.com>
8 tasks
telpirion
pushed a commit
that referenced
this pull request
Jan 18, 2023
Source-Link: googleapis/synthtool@4760d8d Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:f0e4b51deef56bed74d3e2359c583fc104a8d6367da3984fc5c66938db738828 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
8 tasks
dandhlee
pushed a commit
that referenced
this pull request
Feb 6, 2023
Source-Link: googleapis/synthtool@4760d8d Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:f0e4b51deef56bed74d3e2359c583fc104a8d6367da3984fc5c66938db738828 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
8 tasks
Sita04
pushed a commit
that referenced
this pull request
Feb 7, 2023
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <partheniou@google.com>
dandhlee
pushed a commit
that referenced
this pull request
Feb 9, 2023
Co-authored-by: AJ Morozoff <amorozoff@google.com> Co-authored-by: Anthonios Partheniou <partheniou@google.com>
telpirion
pushed a commit
that referenced
this pull request
Mar 13, 2023
Source-Link: googleapis/synthtool@4760d8d Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:f0e4b51deef56bed74d3e2359c583fc104a8d6367da3984fc5c66938db738828 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
telpirion
pushed a commit
that referenced
this pull request
Mar 13, 2023
Co-authored-by: AJ Morozoff <amorozoff@google.com> Co-authored-by: Anthonios Partheniou <partheniou@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This enables grpc tests on python 3 and unifies the app engine and python 2.7 test suite (woohoo).