Add commented variables to make samples more friendly to copy and use#4365
Merged
Conversation
google-cla
Bot
added
the
cla: yes
engelke
reviewed
Jul 23, 2020
| # [START asset_quickstart_search_all_iam_policies] | ||
| from google.cloud import asset_v1 | ||
|
|
||
| # TODO scope = 'Scope of the search' |
Contributor
There was a problem hiding this comment.
Why are these labeled TODO? This is just a description, right, not a future task. Or am I missing something?
Contributor
Author
There was a problem hiding this comment.
I'm following the style in some of our team's existing samples (e.g., createfeed.py)
Is there a particular style I should use for these commented variables?
Contributor
There was a problem hiding this comment.
No, if that's been used before, let's keep it.
busunkim96
approved these changes
Jul 23, 2020
Contributor
Author
|
Resource Exhausted. Can you rerun the tests? Thanks. This PR only added comments so shouldn't affect the test results at all. |
Contributor
|
Okay. If it passes any of them, I'll expect it would pass the other Python
versions, too. If it does, I'll merge it.
…On Thu, Jul 23, 2020 at 4:59 PM yuyifan-google ***@***.***> wrote:
Resource Exhausted. Can you rerun the tests? Thanks. This PR only added
comments so shouldn't affect the test results at all.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#4365 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAT6N556SOZSSLC5RLYKWDR5DFGFANCNFSM4PGFZU3Q>
.
--
Charles Engelke
GCP AppDev DPE
|
arithmetic1728
pushed a commit
to googleapis/python-asset
that referenced
this pull request
Jul 31, 2020
busunkim96
pushed a commit
to googleapis/python-asset
that referenced
this pull request
Aug 4, 2020
engelke
pushed a commit
that referenced
this pull request
Nov 28, 2022
dandhlee
pushed a commit
that referenced
this pull request
Nov 29, 2022
parthea
pushed a commit
to googleapis/google-cloud-python
that referenced
this pull request
Oct 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #
Note: It's a good idea to open an issue first for discussion.
Checklist
nox -s py-3.6(see Test Enviroment Setup)nox -s lint(see Test Enviroment Setup)