Skip to content

Adding error condition to billing check#4272

Merged
crwilcox merged 5 commits into
GoogleCloudPlatform:masterfrom
markmirch:billing_edge
Jul 14, 2020
Merged

Adding error condition to billing check#4272
crwilcox merged 5 commits into
GoogleCloudPlatform:masterfrom
markmirch:billing_edge

Conversation

@markmirch

@markmirch markmirch commented Jul 9, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Additional error check on billing enabled function

Checklist

@markmirch markmirch requested review from a team and ace-n as code owners July 9, 2020 19:40
ace-n
ace-n suggested changes Jul 10, 2020
View reviewed changes
Comment thread functions/billing/main.py
@busunkim96 busunkim96 added the automerge Merge the pull request once unit tests and other checks pass. label Jul 13, 2020
@busunkim96 busunkim96 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 13, 2020
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 13, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 13, 2020
@gcf-merge-on-green

gcf-merge-on-green Bot commented Jul 13, 2020

Copy link
Copy Markdown
Contributor

Your PR has attempted to merge for 3 hours. Please check that all required checks have passed, you have an automerge label, and that all your reviewers have approved the PR

@gcf-merge-on-green

gcf-merge-on-green Bot commented Jul 13, 2020

Copy link
Copy Markdown
Contributor

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, or one of your required reviews was not approved. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green Bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jul 13, 2020
@ace-n ace-n added the automerge Merge the pull request once unit tests and other checks pass. label Jul 14, 2020
@gcf-merge-on-green

gcf-merge-on-green Bot commented Jul 14, 2020

Copy link
Copy Markdown
Contributor

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, or one of your required reviews was not approved. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green Bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jul 14, 2020
@crwilcox crwilcox added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 14, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 14, 2020
@crwilcox crwilcox merged commit 2977bc8 into GoogleCloudPlatform:master Jul 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@busunkim96 busunkim96 busunkim96 approved these changes
@ace-n ace-n ace-n approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@crwilcox crwilcox

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@markmirch @ace-n @busunkim96 @crwilcox @googlebot @kokoro-team