add requirements-test.txt#4266
Merged
Merged
Conversation
googlebot
added
the
cla: yes
Contributor
|
@leahecole Yeah, that's my concern too :) How can we make sure it's working as intended? |
busunkim96
approved these changes
Jul 8, 2020
tmatsuo
approved these changes
Jul 8, 2020
Co-authored-by: Bu Sun Kim <8822365+busunkim96@users.noreply.github.com>
Collaborator
Author
|
@tmatsuo I'll follow up with an adjustment to a requirements-test.txt file today to verify! |
Collaborator
Author
|
The issue won't be considered fixed until I do |
Collaborator
Author
|
I will do part 2 of this tomorrow - the actual test - I need to step away from my desk now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is an experimental PR - I'm not sure if when including the
pip_requirementsfield we also will need to explicitly specifyrequirements.txt(which is the default) as well asrequirements-test.txt. I'll open a separate PR to change a test requirement to see if the bot worksIt'll have to be merged before we consider this fixed
Maybe Fixes #4265
Note: It's a good idea to open an issue first for discussion.
Checklist
nox -s py-3.6(see Test Enviroment Setup)nox -s lint(see Test Enviroment Setup)