Added Events for Cloud Run for Anthos – GCS and PubSub tutorials. Fix… by meteatamel · Pull Request #4232 · GoogleCloudPlatform/python-docs-samples

meteatamel · 2020-07-02T10:17:17Z

…es issue #4231

Description

Fixes #

Note: It's a good idea to open an issue first for discussion.

Checklist

I have followed Sample Guidelines from AUTHORING_GUIDE.MD
README is updated to include all relevant information
Tests pass: nox -s py-3.6 (see Test Enviroment Setup)
Lint pass: nox -s lint (see Test Enviroment Setup)
These samples need a new API enabled in testing projects to pass (let us know which ones)
These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
Please merge this PR for me once it is approved.

…es issue #4231

dinagraves · 2020-07-06T17:06:06Z

Hi Mete - these look like tutorials rather than code samples. Unless you're going to add code samples to go with it, I think the Cloud Run docs would be a better home for these.

meteatamel · 2020-07-06T17:41:57Z

@dinagraves There are 2 samples already for Cloud Run Events (Managed) written by @grant. I simply added instructions for those same 2 samples for Cloud Run Events (Anthos).

grant

Thanks @meteatamel. This matches what we talked about.

I did not test the instructions but I verified the README looks good.

dinagraves

Got it.

dinagraves · 2020-07-06T18:14:23Z

run/events-storage/anthos.md

+Set cluster name, location and platform:
+
+```sh
+gcloud config set run/cluster events-cluster


Later I get an error saying: No cluster named 'events-cluster' in {project_name}. Can you add a step for creating the clusters? https://cloud.google.com/run/docs/gke/setup#create_cluster

In Pub/Sub tutorial, I say at the beginning "It is assumed that you already created a GKE cluster with Events for Cloud Run already installed." but it looks like I forgot to add a similar note to GCS tutorial. I'll do that tomorrow.

I deliberately left out instructions on creating a GKE cluster with Cloud Run Events because the steps are extremely long and error-prone right now (see steps 6, 7 and 8 of this codelab for details) and they'll get much easier very soon.

Can you include the link to the docs for both notes?

The docs are not ready yet. There's Alpha User Guide but they'll be somewhat irrelevant soon. I can link to that, if you think it'll be useful.

I followed this: https://cloud.google.com/run/docs/gke/setup#create_cluster

That creates a GKE cluster with Cloud Run but it doesn't install eventing..You really need to go through that codelab I linked to set things up with Cloud Run Eventing on Anthos.

I added a note to GCS tutorial that a GKE cluster with Events for Cloud Run is needed for the sample. Again, I feel like we shouldn't link to Alpha User Guide and wait for official docs for installation instructions to link to. Feel free to open a tracking bug and assign to me, if needed.

dinagraves · 2020-07-06T18:15:02Z

run/events-storage/anthos.md

+
+```sh
+gcloud config set run/cluster events-cluster
+gcloud config set run/cluster_location europe-west1-b


Should this be eu? Should we give an option to use other locations?

Ran into this error since my cluster was in the US:

Could not find [events-cluster] in [europe-west1-b]. Did you mean [events-cluster] in [us-central1-c]?

It can be EU or US..This is meant to be just an example of a cluster name and location. We can externalize them into env vars, if you think it's better that way.

I think it would be better to put it into env vars given the creation of the clusters is outside this tutorial and could easily be in another region.

I commited a change to externalize these into env variables

dinagraves · 2020-07-06T20:38:57Z

run/events-storage/anthos.md

+```sh
+gcloud builds submit \
+ --tag gcr.io/$(gcloud config get-value project)/$MY_RUN_CONTAINER
+gcloud run deploy $MY_RUN_SERVICE \


Initially got ERROR: (gcloud.run.deploy) [Errno 61] Connection refused

Successfully connected with gcloud container clusters get-credentials events-cluster --zone us-central1-c --project {PROJECT_ID} and ran the deploy command without issue

I don't think the two are related. get-credentials sets up kubectl to talk to the cluster but it should not affect gcloud run deploy. The only thing that can affect deploy is the run/platform gke setting. Make sure it's set to gke to deploy to GKE/Anthos.

dinagraves · 2020-07-06T22:52:18Z

run/events-storage/anthos.md

+```sh
+gcloud alpha events triggers create $MY_GCS_TRIGGER \
+--target-service $MY_RUN_SERVICE \
+--type=com.google.cloud.storage.object.finalize \


Ran into this error

ERROR: (gcloud.alpha.events.triggers.create) Unknown event type: com.google.cloud.storage.object.finalize. If you're trying to use a custom event type, add the "--custom-type" flag.

FYI, when I run the gcloud alpha events types list, it responds with
Listed 0 items.

I did run gcloud components update

My guess is that you don't have run/platform variable set to gke. So, it's trying to deploy to managed and managed does not support com.google.cloud.storage.object.finalize yet.

gcloud config list shows platform = gke

Looks like this person had the same problem: #4228

It's similar but not the same problem. #4228 is with Cloud Run Managed, whereas this PR is with Cloud Run for Anthos. Both features are in alpha and projects need to be whitelisted.

Ah! Should that be noted somewhere? Or are you going wait until it's publicly available to merge this PR?

Grant already submitted samples for Managed in preparation for upcoming Beta. I'm merely mirroring it for Anthos. I think we can merge this as is and if we need to note anything before Beta, this can be done holistically for Managed and Anthos.

meteatamel · 2020-07-15T09:34:56Z

@grant @dinagraves Anything else needed before merging this PR?

dinagraves · 2020-07-15T16:43:36Z

@meteatamel good to go

grant · 2020-07-15T17:19:43Z

I've already approved the PR.

We have 2 approvers. Merging. Thanks for the PR :)

Added Events for Cloud Run for Anthos – GCS and PubSub tutorials. Fix…

5093b9b

…es issue #4231

meteatamel requested review from a team and dinagraves as code owners July 2, 2020 10:17

blunderbuss-gcf bot assigned crwilcox Jul 2, 2020

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 2, 2020

grant self-requested a review July 6, 2020 17:47

grant approved these changes Jul 6, 2020

View reviewed changes

dinagraves reviewed Jul 6, 2020

View reviewed changes

meteatamel added 2 commits July 7, 2020 15:40

Externalized cluster name and location into env vars

46adb80

Added a note to let people know that a cluster in needed

1c4f996

dinagraves approved these changes Jul 7, 2020

View reviewed changes

nanukn mentioned this pull request Jul 9, 2020

ERROR: (gcloud.alpha.events.triggers.create) Unknown event type: com.google.cloud.auditlog.event #4228

Closed

Merge branch 'master' into master

da358b1

grant merged commit 6bcf974 into GoogleCloudPlatform:master Jul 15, 2020

grant assigned meteatamel and unassigned crwilcox Jul 15, 2020

Conversation

meteatamel commented Jul 2, 2020

Description

Checklist

Uh oh!

dinagraves commented Jul 6, 2020

Uh oh!

meteatamel commented Jul 6, 2020

Uh oh!

grant left a comment

Choose a reason for hiding this comment

Uh oh!

dinagraves left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

meteatamel Jul 7, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dinagraves Jul 6, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dinagraves Jul 6, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

meteatamel commented Jul 15, 2020

Uh oh!

dinagraves commented Jul 15, 2020

Uh oh!

grant commented Jul 15, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

meteatamel Jul 7, 2020 •

edited

Loading

dinagraves Jul 6, 2020 •

edited

Loading

dinagraves Jul 6, 2020 •

edited

Loading