[bigtable] update reads/filters region tags#4065
Merged
Merged
Conversation
googlebot
added
the
cla: yes
kurtisvg
approved these changes
Jun 16, 2020
kurtisvg
left a comment
kurtisvg
left a comment
Contributor
There was a problem hiding this comment.
LGTM - but looks like there are still some linting issues
Member
Author
|
@kurtisvg I'm not sure why this keeps failing lint. I run it locally and it passes and then every time a new lint error appears in kokoro I fixed the ones the kokoro command produces but then
|
make tag one sample
Reran lint
kurtisvg
force-pushed
the
bigtable-region-tags
branch
from
b6b4a1d to
07a6961
Compare
busunkim96
approved these changes
Jun 19, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.