[iam] fix: use uuid4's first part for test#3565
Merged
Merged
Conversation
googlebot
added
the
cla: yes
gguuss
reviewed
Apr 28, 2020
| project_id = os.environ['GCLOUD_PROJECT'] | ||
| rand = str(random.randint(0, 1000)) | ||
| name = 'python-test-' + rand | ||
| name = 'python-test-{}'.format(str(uuid.uuid4()).split('-')[0]) |
Contributor
There was a problem hiding this comment.
I feel like a deterministic value based on machine ID / mac address would be ideal - are you just using UUID4 for a random value?
Contributor
Author
There was a problem hiding this comment.
Yes. Due to the length limitation, I needed to use only the first part, but it's still far better than random.randint(0, 1000).
gguuss
approved these changes
Apr 28, 2020
gguuss
left a comment
gguuss
left a comment
Contributor
There was a problem hiding this comment.
LGTM, random UUID is probably better than a random value to avoid machine collisions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #3499