Add sample for connecting to SQL Server with SQLAlchemy/pyodbc#3135
Conversation
googlebot
added
the
cla: yes
shubha-rajan
force-pushed
the
sqlserver-connection
branch
3 times, most recently
from
85f54ed to
250a97b
Compare
|
Test errors are because the container we run tests are in doesn't have the pyodbc driver installed. Normally I would recommend using a pure python driver, but it seems like pymssql is deprecated. We may need to update the testing container to include this driver. |
|
@kurtisvg yeah, Microsoft has officially said that they're only supporting pyodbc. The container also needs to include the Microsoft ODBC driver. Steps for installing are in the Dockerfile. |
There was a problem hiding this comment.
Can we inline this logic below so it's included in the sample?
There was a problem hiding this comment.
I moved the region tag up to include getting the parameters from the env vars, so this is already included. I can still inline it if that's more readable
|
@shubha-rajan You'll need to update the testing dockerfile as well: https://github.com/googleapis/testing-infra-docker/blob/master/python/googleapis/python-multi/Dockerfile |
|
@kurtisvg I opened a PR here googleapis/testing-infra-docker#60 but Github won't let me add reviewers (possibly because I'm not a collaborator on that repo?) |
shubha-rajan
added
the
kokoro:force-run
kokoro-team
removed
kokoro:force-run
busunkim96
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
Co-Authored-By: Bu Sun Kim <8822365+busunkim96@users.noreply.github.com>
Co-Authored-By: Kurtis Van Gent <31518063+kurtisvg@users.noreply.github.com>
Co-Authored-By: Kurtis Van Gent <31518063+kurtisvg@users.noreply.github.com>
Co-Authored-By: Kurtis Van Gent <31518063+kurtisvg@users.noreply.github.com>
Co-Authored-By: Kurtis Van Gent <31518063+kurtisvg@users.noreply.github.com>
Co-Authored-By: Kurtis Van Gent <31518063+kurtisvg@users.noreply.github.com>
Co-Authored-By: Kurtis Van Gent <31518063+kurtisvg@users.noreply.github.com>
shubha-rajan
force-pushed
the
sqlserver-connection
branch
from
d03b8b7 to
f280496
Compare
5 participants
Also includes setup for deploying to App Engine Flexible. I'd like some guidance on how to go about resolving the Kokoro failures, PTAL. The reason I had to deploy with a custom runtime was to resolve that specific error, which is a result of not having unixODBC installed.