-
Notifications
You must be signed in to change notification settings - Fork 6.7k
Add GAE billing tests + fix region tags #2774
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
e6e5b6d
Add GAE billing limit sample
06341b7
Merge branch 'master' into gae-billing
14b90d3
Fix lint (since I cant run it locally)
cf311f0
Fix lint v2
1e1add1
Add missing region tag blocks
7a92064
Add region tags to imports
bb7dc37
Add tests
ad2f258
Actually save lint fixes :)
2c28ec5
Fix lint
2891c1e
Merge branch 'master' into gae-billing-tests-2772
aa88f4c
Add tests
b8e4c84
Actually save lint fixes :)
536e7a5
Fix lint
498baf6
Only test GCF in Python 3.7
0081bec
Merge branch 'gae-billing-tests-2772' of http://github.com/GoogleClou…
485e117
GCF Py3.7 only, take 2
a4f58c3
DBG commit 1
e08fb81
Remove DBG commit + capture Python version correctly
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI, this code is completely wrong.
This code checks the default Python version, rather than Python version in the nox session.
This resulted in disabling all the tests under functions directory. #3767 removed this code block then our tests started to fail.